[15] RFR(T): 8248265: compiler/ciReplay tests fail with AOT compiled java.base

[Igor Ignatyev]

+1

-- Igor

> On Jun 26, 2020, at 7:25 AM, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> 
> Hi Tobias,
> 
> Looks good.
> 
> Best regards,
> Nils Eliasson
> 
> On 2020-06-26 12:14, Tobias Hartmann wrote:
>> Hi,
>> 
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8248265
>> http://cr.openjdk.java.net/~thartmann/8248265/webrev.00/
>> 
>> With AOT compiled java.base, we call the test method EmptyMain::main through
>> JavaCalls::call_helper(). The fix for JDK-8247832 restored the old behavior that empty methods are
>> not called: https://hg.openjdk.java.net/jdk/jdk15/rev/94025f9e6a0d#l2.36
>> 
>> As a result, EmptyMain::main is not called and therefore also not compiled. The test fails because
>> -XX:CICrashAt=1 triggers no VM crash. Empty methods not being called is expected behavior. The test
>> should use a non-empty method to trigger compilation.
>> 
>> Thanks,
>> Tobias
>