[15] RFR(T): 8248265: compiler/ciReplay tests fail with AOT compiled java.base

[Vladimir Kozlov]

On 6/26/20 3:14 AM, Tobias Hartmann wrote:
> Hi,
> 
> please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8248265
> http://cr.openjdk.java.net/~thartmann/8248265/webrev.00/

I prefer an assign to a static variable. Printing is very complex code.

> 
> With AOT compiled java.base, we call the test method EmptyMain::main through
> JavaCalls::call_helper(). The fix for JDK-8247832 restored the old behavior that empty methods are
> not called: https://hg.openjdk.java.net/jdk/jdk15/rev/94025f9e6a0d#l2.36

These changes are done for JDK-8247992. JDK-8247832 is not related and not fixed yet.

> 
> As a result, EmptyMain::main is not called and therefore also not compiled. The test fails because
> -XX:CICrashAt=1 triggers no VM crash. Empty methods not being called is expected behavior. The test
> should use a non-empty method to trigger compilation.

Yes.

Thanks,
Vladimir

> 
> Thanks,
> Tobias
>