RFR(S): 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101"

[Patric Hedlin]

Hi Vladimir,

On 2020-06-27 00:59, Vladimir Kozlov wrote:
> Hi Patric,
>
> You can move #ifdef ASSERT to put if(check_estimate) under it.
Personally I prefer an empty statement list over an unused 
parameter/variable, but I can certainly move the *if (check...* inside 
the conditional ASSERT section.

Assuming no refresh required.

Thanks for reviewing.

/Patric

>
> Thanks,
> Vladimir
>
> On 6/26/20 7:15 AM, Patric Hedlin wrote:
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8234605
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8234605/
>>
>>
>> Turning assert into (universal) logging. This issue (now) manifest 
>> itself very seldom (typically on small estimates) and has thus served 
>> its purpose to help trim the node budget estimates to some reasonable 
>> level. Logging should be sufficient going forward.
>>
>>
>> Testing: tier1-2
>>
>>
>> Best regards,
>> Patric