[15] RFR(T): 8248265: compiler/ciReplay tests fail with AOT compiled java.base

[Tobias Hartmann]

Thanks Vladimir!

Best regards,
Tobias

On 29.06.20 20:06, Vladimir Kozlov wrote:
> Good.
> 
> Thanks,
> Vladimir
> 
> On 6/28/20 11:06 PM, Tobias Hartmann wrote:
>> Hi Vladimir,
>>
>> Thanks for the review!
>>
>> On 26.06.20 20:37, Vladimir Kozlov wrote:
>>> I prefer an assign to a static variable. Printing is very complex code.
>>
>> Okay, my intention for the printing was that it would help to diagnose similar issues (method not
>> called) but that should never happen with a non-empty method anyway. Here's a new version:
>> http://cr.openjdk.java.net/~thartmann/8248265/webrev.01/
>>
>>>> With AOT compiled java.base, we call the test method EmptyMain::main through
>>>> JavaCalls::call_helper(). The fix for JDK-8247832 restored the old behavior that empty methods are
>>>> not called: https://hg.openjdk.java.net/jdk/jdk15/rev/94025f9e6a0d#l2.36
>>>
>>> These changes are done for JDK-8247992. JDK-8247832 is not related and not fixed yet.
>>
>> Right, I've linked the right changeset but mentioned the wrong bug (copy-paste error from the
>> clipboard).
>>
>> Thanks,
>> Tobias
>>