RFR: 8240528: OopMap cleanup

Tobias Hartmann tobias.hartmann at oracle.com
Thu Mar 5 06:24:56 UTC 2020


Hi Claes,

looks good to me but I think the assert in oopMap.hpp:213 is not needed because the bounds are
already checked in GrowableArray::at(). Also, it should be index < length() not <=.

Best regards,
Tobias

On 04.03.20 16:12, Claes Redestad wrote:
> Hi,
> 
> found some dead code in and around OopMap, including a number of fields
> exported via vmStructs that are unused since JDK-8064458.
> 
> Also simplified some manual memory management by using a GrowableArray
> instead.
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8240528
> Webrev: http://cr.openjdk.java.net/~redestad/8240528/open.00
> 
> Testing: tier1-2
> 
> Thanks!
> 
> /Claes


More information about the hotspot-compiler-dev mailing list