RFR(XS): 8239335: C2: assert((Value(phase) == t) || (t != TypeInt::CC_GT && t != TypeInt::CC_EQ)) failed: missing Value() optimization

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Mar 5 17:26:31 UTC 2020


Good.

Thanks,
Vladimir

On 3/5/20 7:06 AM, Roland Westrelin wrote:
> 
> Hi Vladimir,
> 
> Thanks for looking at this.
> 
>> It needs explanation comment in the code for all checks there.
> 
> What about this:
> http://cr.openjdk.java.net/~roland/8239335/webrev.01/
> 
>> Do I understand correctly that you relaxed condition for constant interfaces which would have
>> _klass_is_exact set?
> 
> Yes because in that case AFAIU, the subclass can only a constant class
> pointer and we can trust that we are actually testing an interface.
> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list