[aarch64-port-dev ] RFR(S): 8239914: AArch64: Combine add/sub with comparison against zero

[Pengfei Li]

Hi,

> Indeed. We need to think carefully about the way we review (and, indeed,
> write) AArch64 patches. This small one might well have got through to
> production without its fatal flaw being noticed. In this case, though, the
> review process worked.
> 
> Unit tests are good, but we need to make sure that they test the corner cases.
> Every arithmetic instruction can overflow.

I agree. Appreciate for your review.

--
Thanks,
Pengfei