RFR: 8240846: Zero VM is broken after JDK-8238681: UseSSE not defined

[Robbin Ehn]

On 2020-03-13 09:12, Aleksey Shipilev wrote:
> On 3/13/20 1:31 AM, jiefu(傅杰) wrote:
>> diff -r 15d69d370743 src/hotspot/share/compiler/compileBroker.cpp
>> --- a/src/hotspot/share/compiler/compileBroker.cpp      Thu Mar 12 16:05:07 2020 -0700
>> +++ b/src/hotspot/share/compiler/compileBroker.cpp      Fri Mar 13 08:29:26 2020 +0800
>> @@ -1328,7 +1328,7 @@
>>     // do the compilation
>>     if (method->is_native()) {
>>       if (!PreferInterpreterNativeStubs || method->is_method_handle_intrinsic()) {
>> -#ifdef X86
>> +#if defined(X86) && !defined(ZERO)
>>         // The following native methods:
>>         //
>>         // java.lang.Float.intBitsToFloat
>> @@ -1350,7 +1350,7 @@
>>               method->intrinsic_id() == vmIntrinsics::_doubleToRawLongBits))) {
>>           return NULL;
>>         }
>>
>> -#endif // X86
>> +#endif // X86 && !ZERO
>>         // To properly handle the appendix argument for out-of-line calls we are using a small trampoline that
>>         // pops off the appendix argument and jumps to the target (see gen_special_dispatch in SharedRuntime).
>> ------------------------------------
> 
> The fix came off badly formatted, please consider webrev next time?
> 
> I believe this addition is safe, as Zero is not supposed to call that method at all? If so, looks good!
> 

+1, thanks.

/Robbin