8240846: Zero VM is broken after JDK-8238681: UseSSE not defined(Internet mail)

jiefu(傅杰) jiefu at tencent.com
Fri Mar 13 09:03:04 UTC 2020


Thanks Vladimir Ivanov for your review.
Pushed.

Best regards,
Jie

On 2020/3/13, 4:52 PM, "Vladimir Ivanov" <vladimir.x.ivanov at oracle.com> wrote:

    Looks good, Jie.
    
    Best regards,
    Vladimir Ivanov
    
    On 13.03.2020 03:31, jiefu(傅杰) wrote:
    > Hi all,
    > 
    > JBS: https://bugs.openjdk.java.net/browse/JDK-8240846
    > 
    > May I get reviews for this small fix?
    > ------------------------------------
    > 
    > diff -r 15d69d370743 src/hotspot/share/compiler/compileBroker.cpp
    > 
    > --- a/src/hotspot/share/compiler/compileBroker.cpp      Thu Mar 12 16:05:07 2020 -0700
    > 
    > +++ b/src/hotspot/share/compiler/compileBroker.cpp      Fri Mar 13 08:29:26 2020 +0800
    > 
    > @@ -1328,7 +1328,7 @@
    > 
    >     // do the compilation
    > 
    >     if (method->is_native()) {
    > 
    >       if (!PreferInterpreterNativeStubs || method->is_method_handle_intrinsic()) {
    > 
    > -#ifdef X86
    > 
    > +#if defined(X86) && !defined(ZERO)
    > 
    >         // The following native methods:
    > 
    >         //
    > 
    >         // java.lang.Float.intBitsToFloat
    > 
    > @@ -1350,7 +1350,7 @@
    > 
    >               method->intrinsic_id() == vmIntrinsics::_doubleToRawLongBits))) {
    > 
    >           return NULL;
    > 
    >         }
    > 
    > -#endif // X86
    > 
    > +#endif // X86 && !ZERO
    > 
    > 
    > 
    >         // To properly handle the appendix argument for out-of-line calls we are using a small trampoline that
    > 
    >         // pops off the appendix argument and jumps to the target (see gen_special_dispatch in SharedRuntime).
    > ------------------------------------
    > 
    > Thanks a lot.
    > Best regards,
    > Jie
    > 
    
    



More information about the hotspot-compiler-dev mailing list