[15] RFR: [JVMCI/Graal] add JFR compiler phase/inlining events

Jamsheed C M jamsheed.c.m at oracle.com
Fri Mar 13 14:18:59 UTC 2020


Hi Tobias,

Thank you for the review and feedback

On 13/03/2020 19:27, Tobias Hartmann wrote:
> Hi Jamsheed,
>
> On 26.02.20 03:05, Jamsheed C M wrote:
>> webrev: http://cr.openjdk.java.net/~jcm/8193210/webrev/
> Looks good to me but I'm not a JFR expert.
>
> Noticed the following:
> - compileBroker.cpp:595 Wrap entire method in #if INCLUDE_JFR and use JFR_ONLY at call.
yes i will do this.
>   Or maybe
> this method should be moved to jfrType.cpp?
> - JFR.java:28 Seems to be unused

will remove it.

Best regards

Jamsheed

>
> Best regards,
> Tobias


More information about the hotspot-compiler-dev mailing list