RFR: 8241074: JDK-8240363 broke the build on AArch64

Erik Österlund erik.osterlund at oracle.com
Mon Mar 16 16:04:24 UTC 2020


Hi,

My recent refactoring from JDK-8240363 broke the build on AArch64. I 
asked Andrew to sanity check it before pushing,
but I think he might have had precompiled headers enabled.

I cross compiled it and found that I need the following missing include:

diff --git a/src/hotspot/share/opto/constantTable.cpp 
b/src/hotspot/share/opto/constantTable.cpp
index 5d6a5df189f..9f0f1c7dbfd 100644
--- a/src/hotspot/share/opto/constantTable.cpp
+++ b/src/hotspot/share/opto/constantTable.cpp
@@ -24,6 +24,7 @@

  #include "precompiled.hpp"
  #include "asm/codeBuffer.hpp"
+#include "asm/macroAssembler.hpp"
  #include "opto/block.hpp"
  #include "opto/constantTable.hpp"
  #include "opto/machnode.hpp"

Otherwise I get the following compilation error:

src/hotspot/share/opto/constantTable.cpp: In member function 'void 
ConstantTable::emit(CodeBuffer&)':
src/hotspot/share/opto/constantTable.cpp:117:23: error: variable 
'MacroAssembler _masm' has initializer but incomplete type
    MacroAssembler _masm(&cb);
                        ^
src/hotspot/share/opto/constantTable.cpp: In member function 'void 
ConstantTable::fill_jump_table(CodeBuffer&, MachConstantNode*, 
GrowableArray<Label*>) const':
src/hotspot/share/opto/constantTable.cpp:237:23: error: variable 
'MacroAssembler _masm' has initializer but incomplete type
    MacroAssembler _masm(&cb);

This change is trivial.

Thanks,
/Erik


More information about the hotspot-compiler-dev mailing list