RFR: 8241074: JDK-8240363 broke the build on AArch64

Andrew Haley aph at redhat.com
Tue Mar 17 09:46:53 UTC 2020


On 3/16/20 4:04 PM, Erik Österlund wrote:
> My recent refactoring from JDK-8240363 broke the build on AArch64. I 
> asked Andrew to sanity check it before pushing,
> but I think he might have had precompiled headers enabled.

I didn't use precompiled headers. This is shared code, and it uses
MacroAssembler, so it surely needs "asm/macroAssembler.hpp" to be
included.

On all targets, including AArch64, macroAssembler.hpp seems to get
pulled in as a transitive dependency. I don't know why that didn't
happen on your AArch64 cross-build.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-compiler-dev mailing list