RFR(S): 8240335: C2: assert(found_sfpt) failed: no node in loop that's not input to safepoint

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Mar 18 18:22:42 UTC 2020


On 3/18/20 3:46 AM, Roland Westrelin wrote:
> 
> Thanks for reviewing this.
> 
>> I think in wait_for_region_igvn() method it should be '} else if () {' if 'delay' set to 'true' to avoid additional checks:
>>
>> +        delay = true;
>> +      } else if(...
>>
>>
>> It is also better to use faster method worklist.member() instead of worklist.contains().
> 
> Right. Do we want to overload contains() in Unique_Node_List to catch
> such a mistake?

Yes, but not in this fix. We may need to run testing with it and fix all found places. File separate RFE.

> 
> http://cr.openjdk.java.net/~roland/8240335/webrev.01/

The rest is good. Please test.

> 
> Roland.
> 

Thanks,
Vladimir


More information about the hotspot-compiler-dev mailing list