8241319: WB_GetCodeBlob doesn't have ResourceMark

Leonid Mesnik leonid.mesnik at oracle.com
Fri Mar 20 22:03:07 UTC 2020


Igor, Tobias
Thank you for review

Leonid

> On Mar 20, 2020, at 5:47 AM, Igor Ignatev <igor.ignatyev at oracle.com> wrote:
> 
>> 
>> On Mar 20, 2020, at 5:03 AM, Tobias Hartmann <Tobias.Hartmann at oracle.com> wrote:
>> 
>> Hi Leonid,
>> 
>>> On 19.03.20 22:22, Leonid Mesnik wrote:
>>> diff -r 0daa6b52ba56 src/hotspot/share/prims/whitebox.cpp
>>> --- a/src/hotspot/share/prims/whitebox.cpp      Tue Mar 17 14:13:52 2020 +0000
>>> +++ b/src/hotspot/share/prims/whitebox.cpp      Thu Mar 19 13:22:35 2020 -0700
>>> @@ -1513,6 +1513,7 @@
>>> };
>>> 
>>> static jobjectArray codeBlob2objectArray(JavaThread* thread, JNIEnv* env, CodeBlobStub* cb) {
>>> +  ResourceMark rm;
>>>   jclass clazz = env->FindClass(vmSymbols::java_lang_Object()->as_C_string());
>>>   CHECK_JNI_EXCEPTION_(env, NULL);
>>>   jobjectArray result = env->NewObjectArray(4, clazz, NULL);
>>> 
>> 
>> That looks good to me.
> +1
> — Igor
>> 
>> Best regards,
>> Tobias



More information about the hotspot-compiler-dev mailing list