RFR: 8241438: Move IntelJccErratum mitigation code to platform-specific code

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed Mar 25 16:24:37 UTC 2020


Hi Erik,

Thanks for taking care of the cleanup.

> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.01/

It would be nice to do something with Node::Flag_intel_jcc_erratum flag 
as well.

Though it's not guarded by #ifdefs, it is clearly x86-specific.

Best regards,
Vladimir Ivanov

> 
> Incremental:
> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.00_01/
> 
> Thanks,
> /Erik
> 
>> Thanks,
>> Vladimir
>>
>> On 3/23/20 6:09 AM, Erik Österlund wrote:
>>> Hi,
>>>
>>> There is some platform-specific code in PhaseOutput that deals with 
>>> the IntelJccErratum mitigation,
>>> which is ifdef:ed in shared code. It should move to platform-specific 
>>> code.
>>>
>>> This patch exposes the iteration state of PhaseOutput, which allows 
>>> hiding the Intel-specific code
>>> completely in x86-specific files.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.00/
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8241438
>>>
>>> Thanks,
>>> /Erik
> 


More information about the hotspot-compiler-dev mailing list