[15] RFR(XS): 8241595: Fix missing debug_orig information in Ideal Graph Visualizer

Christian Hagedorn christian.hagedorn at oracle.com
Thu Mar 26 08:17:31 UTC 2020


Thank you for your review Nils!

Best regards,
Christian

On 26.03.20 09:14, Nils Eliasson wrote:
> +1
> 
> // Nils
> 
> On 2020-03-25 18:24, Vladimir Kozlov wrote:
>> Looks good.
>>
>> Thanks,
>> Vladimir
>>
>> On 3/25/20 5:46 AM, Christian Hagedorn wrote:
>>> Hi
>>>
>>> Please review the following small enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-8241595
>>> http://cr.openjdk.java.net/~chagedorn/8241595/webrev.00/
>>>
>>> The debug_orig information is never printed for the Ideal Graph 
>>> Visualizer since temp_set->test_set() is checked wrongly. This fix 
>>> reuses the dump_orig() method to print and show the same information 
>>> in the Ideal Graph Visualizer as when dumping a node on the command 
>>> line.
>>>
>>> Thank you!
>>>
>>> Best regards,
>>> Christian


More information about the hotspot-compiler-dev mailing list