[15] RFR (L): 8241436: C2: Factor out C2-specific code from MacroAssembler

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Thu Mar 26 10:07:53 UTC 2020


Thanks for the taking a look, Andrew.

> It's not clear to me that this is a show-stopper for your patch. I think
> this is entirely unrelated and needs a separate fix. An ultra-cautious
> approach suggests delaying your patch until I get to the bottom of this.
> However, if you would prefer I'm happy to let your patch go through and
> leave this problem for a follow-up JIRA. Either way the -compiler2
> option is not going to build on AArch64.

It doesn't look like a show-stopper to me as well, so I'd prefer to 
proceed with the patch.

Another option is to do minimal changes on AARCH64 (since adlc generates 
C2_MA usages) or even leave it as is (continue generating MA usages on 
AARCH64)  and let port maintainers refactor the code at their own 
discretion.

Let me know what you prefer.

Best regards,
Vladimir Ivanov


More information about the hotspot-compiler-dev mailing list