[15] RFR (L): 8241436: C2: Factor out C2-specific code from MacroAssembler

[Vladimir Ivanov]

Thanks for the review, Andrew.

Best regards,
Vladimir Ivanov

On 26.03.2020 14:13, Andrew Dinn wrote:
> Hi Vladimir,
> 
> On 26/03/2020 10:07, Vladimir Ivanov wrote:
>> Thanks for the taking a look, Andrew.
>>
>>> It's not clear to me that this is a show-stopper for your patch. I think
>>> this is entirely unrelated and needs a separate fix. An ultra-cautious
>>> approach suggests delaying your patch until I get to the bottom of this.
>>> However, if you would prefer I'm happy to let your patch go through and
>>> leave this problem for a follow-up JIRA. Either way the -compiler2
>>> option is not going to build on AArch64.
>>
>> It doesn't look like a show-stopper to me as well, so I'd prefer to
>> proceed with the patch.
>>
>> Another option is to do minimal changes on AARCH64 (since adlc generates
>> C2_MA usages) or even leave it as is (continue generating MA usages on
>> AARCH64)  and let port maintainers refactor the code at their own
>> discretion.
>>
>> Let me know what you prefer.
> I say go ahead and push your patch as is. I raised JDK-8241665 for the
> AArch4 failure and will provide a patch ASAP.
> 
> regards,
> 
> 
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill
>