RFR(S): 8241492: Strip mining not working for test/hotspot/jtreg/compiler/c2/Test6850611.java

Nils Eliasson nils.eliasson at oracle.com
Mon Mar 30 07:52:58 UTC 2020


+1

Best regards,

Nils Eliasson

On 2020-03-30 09:28, Tobias Hartmann wrote:
> Hi Roland,
>
> looks good to me.
>
> loopnode.cpp:1594 "Used" -> "Use"
>
> Best regards,
> Tobias
>
> On 27.03.20 11:17, Roland Westrelin wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8241492
>> http://cr.openjdk.java.net/~roland/8241492/webrev.00/
>>
>> The loop is strip mined but the computation of the inner loop number of
>> iterations is wrong. It is the min of the number of iterations left and
>> LoopStripMiningIter. In this case, the number of iterations left
>> (guaranteed always positive) is greater than the max signed int but the
>> min() that's used operates on signed ints so even though there's a large
>> number of iterations left, the resulting number of iterations is not
>> LoopStripMiningIter. Switching to a unsigned min() fixes this.
>>
>> Roland.
>>


More information about the hotspot-compiler-dev mailing list