RFR(S): 8241041: C2: "assert((Value(phase) == t) || (t != TypeInt::CC_GT && t != TypeInt::CC_EQ)) failed: missing Value() optimization" still happens after fix for 8239335

[Roland Westrelin]

Hi Tobias,

> looks good to me.

Thanks for the review.

> Comments (no new webrev required):
> - "Node* cmp" and "const Type* t" declarations should be part of the #ifdef ASSERT.

Actually, there's another #ifdef ASSERT surrounding the 2 I added so
they should be removed.

> - Please replace the ShouldNotReachHere by a fatal or assert(false) with a debug message

I'll do that.

Roland.