RFR(S): 8241556: Memory leak if -XX:CompileCommand is set

[Man Cao]

Thanks for the review!

> Just out of curiosity, why are you running with some intrinsics disabled
in production?
The production workload is actually running
with -XX:CompileCommand="exclude,com.google.Foo::bar", not with any value
for DisableIntrinsic.
This bug leaked many instances of one-byte empty string "\0", allocated
in DirectiveSet::canonicalize_disableintrinsic().

-Man


On Mon, Mar 30, 2020 at 1:52 AM Tobias Hartmann <tobias.hartmann at oracle.com>
wrote:

> Hi Man,
>
> On 25.03.20 00:21, Man Cao wrote:
> > Could I have reviews for this fix for a memory leak? This memory leak is
> > pretty significant in production, and it took us weeks to identify the
> root
> > cause.
>
> Nice, good catch!
>
> Just out of curiosity, why are you running with some intrinsics disabled
> in production?
>
> > Webrev: https://cr.openjdk.java.net/~manc/8241556/webrev.00/
>
> Looks good to me.
>
> Thanks,
> Tobias
>