RFR(XS): Provide information when hitting a HaltNode for architectures other than x86

Andrew Haley aph at redhat.com
Wed May 6 08:19:26 UTC 2020


On 5/6/20 8:25 AM, Liu, Xin wrote:
>     Currently in AArch64 MacroAssembler::stop(), it will generate many
>     register saving instructions by pusha() before calling to debug64(). But
>     I think debug64() only uses the regs[] and pc arguments when
>     ShowMessageBoxOnError is on. Maybe we should at least only do the saving
>     and pc arg passing when ShowMessageBoxOnError is on in
>     MacroAssembler::stop(), as what x86 does in macroAssembler_x86.cpp?

Maybe we should think about a better way to do it. All we have
to do, after all, is put the reason into, say, r8, and execute
a trap. We don't need to push and pop anything because the trap
handler will do that.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-compiler-dev mailing list