[aarch64-port-dev ] [EXT] Re: RFR(XS): Provide information when hitting a HaltNode for architectures other than x86

[Doerr, Martin]

Hi lx,

> It's my fault. I should associate with the bug id in the subject. I will double
> check the email subject before sending.
Thanks and no problem.

> Now this thread becomes an RFR for JDK-8244949.  So, you just try it out in
> ppc?
JDK-8244949 is just for PPC64. I think it's large enough to keep it separate. I've left out the addition of the HaltNode message which is subject of your change which is still wanted.
I don't know if Andrew wants to integrate his aarch64 part into your change or push it separately.
It would be nice to do it also for s390, but I have limited time for this platform. We could live without my enhancement or do it later.

> I am not reviewer.  just my 2 cents.
Your review is appreciated.

> 1. nativeInst_ppc.hpp.
> I think the return type of get_stop_type() should be 'int' here.
> 
>  bool get_stop_type() {
>     return MacroAssembler::tdi_get_si16(long_at(0),
> Assembler::traptoUnconditional, 0);
>  }
> 
> 2. nativeInst_ppc.cpp
> NativeInstruction::is_sigill_zombie_not_entrant_at() comment still says "iff
> !UseSIGTRAP".
Thanks a lot for reviewing my preliminary version. I'll update the webrev in place before sending a RFR email.

> 3. TrapBasedNotEntrantChecks is a product option.  Is it too abrupt to drop it?
> This wiki defines the lifecycle of a Jvm option, but I believe this one is special.
> It's ppc only.
The point is "It's ppc only". We don't apply the strict rules as the PPC flags are not properly categorized (product, diagnostic, develop, ...) and we don't expect anyone to set this flag in production.

Best regards,
Martin


> -----Original Message-----
> From: Liu, Xin <xxinliu at amazon.com>
> Sent: Samstag, 16. Mai 2020 02:25
> To: Doerr, Martin <martin.doerr at sap.com>; Andrew Haley
> <aph at redhat.com>; Derek White <derekw at marvell.com>; Ningsheng Jian
> <ningsheng.jian at arm.com>; hotspot-compiler-dev at openjdk.java.net
> Cc: aarch64-port-dev at openjdk.java.net
> Subject: Re: [aarch64-port-dev ] [EXT] Re: RFR(XS): Provide information
> when hitting a HaltNode for architectures other than x86
> 
> Hi, Martin,
> It's my fault. I should associate with the bug id in the subject. I will double
> check the email subject before sending.
> 
> Now this thread becomes an RFR for JDK-8244949.  So, you just try it out in
> ppc?
> If it works well, we will apply this approach to both 390 and aarch64?
> 
> I am not reviewer.  just my 2 cents.
> 1. nativeInst_ppc.hpp.
> I think the return type of get_stop_type() should be 'int' here.
> 
>  bool get_stop_type() {
>     return MacroAssembler::tdi_get_si16(long_at(0),
> Assembler::traptoUnconditional, 0);
>  }
> 
> 2. nativeInst_ppc.cpp
> NativeInstruction::is_sigill_zombie_not_entrant_at() comment still says "iff
> !UseSIGTRAP".
> 
> 3. TrapBasedNotEntrantChecks is a product option.  Is it too abrupt to drop it?
> This wiki defines the lifecycle of a Jvm option, but I believe this one is special.
> It's ppc only.
> https://wiki.openjdk.java.net/display/HotSpot/Hotspot+Command-
> line+Flags%3A+Kinds%2C+Lifecycle+and+the+CSR+Process
> 
> Thanks,
> --lx
> 
> 
> 
> On 5/15/20, 3:38 AM, "Doerr, Martin" <martin.doerr at sap.com> wrote:
> 
>     CAUTION: This email originated from outside of the organization. Do not
> click links or open attachments unless you can confirm the sender and know
> the content is safe.
> 
> 
> 
>     Exactly, we get stop type + stop message + registers + instructions
> (unfortunately not disassembled for some reason) + nice stack trace.
> 
>     Best regards,
>     Martin
> 
> 
>     > -----Original Message-----
>     > From: Andrew Haley <aph at redhat.com>
>     > Sent: Freitag, 15. Mai 2020 10:57
>     > To: Doerr, Martin <martin.doerr at sap.com>; Derek White
>     > <derekw at marvell.com>; Ningsheng Jian <ningsheng.jian at arm.com>;
> Liu,
>     > Xin <xxinliu at amazon.com>; hotspot-compiler-dev at openjdk.java.net
>     > Cc: aarch64-port-dev at openjdk.java.net
>     > Subject: Re: [aarch64-port-dev ] [EXT] Re: RFR(XS): Provide information
>     > when hitting a HaltNode for architectures other than x86
>     >
>     > On 5/14/20 8:24 PM, Doerr, Martin wrote:
>     > > Just for you upfront in case you would like to take a look:
>     > > https://bugs.openjdk.java.net/browse/JDK-8244949
>     > >
>     >
> http://cr.openjdk.java.net/~mdoerr/8244949_ppc64_asm_stop/webrev.00/
>     >
>     > That's nice: it's a lot more full-featured than what I did. and AFAICS
>     > you'll get the registers printed in the VM error log.
>     >
>     > --
>     > Andrew Haley  (he/him)
>     > Java Platform Lead Engineer
>     > Red Hat UK Ltd. <https://www.redhat.com>
>     > https://keybase.io/andrewhaley
>     > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
>