RFR: 8244819: hsdis does not compile with binutils 2.34+

[Yasumasa Suenaga]

Thanks Vladimir!

Yasumasa

On 2020/05/19 2:57, Vladimir Kozlov wrote:
> Looks good.
> 
> Thanks,
> Vladimir
> 
> On 5/12/20 6:12 AM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> Please review this change:
>>
>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8244819
>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8244819/webrev.00/
>>
>> binutils 2.34 introduces new section flag: SEC_ELF_OCTETS, and it affects arguments of bfd_octets_per_byte() [1]. So we can see new compiler error as below:
>>
>> ```
>> hsdis.c:571:28: error: too few arguments to function 'bfd_octets_per_byt
>> '
>>    571 | dinfo->octets_per_byte = bfd_octets_per_byte (abfd);
>>        | ^~~~~~~~~~~~~~~~~~~
>> In file included from hsdis.c:58:
>> build/linux-amd64/bfd/bfd.h:1999:14: note: declared here
>>   1999 | unsigned int bfd_octets_per_byte (const bfd *abfd,
>>        | ^~~~~~~~~~~~~~~~~~~
>> ```
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> [1] https://sourceware.org/git/?p=binutils-gdb.git;h=618265039f697eab9e72bb58b95fc2d32925df58