RFR(M): 8244504: C2: refactor counted loop code in preparation for long counted loop
Tobias Hartmann
tobias.hartmann at oracle.com
Wed May 27 11:04:42 UTC 2020
Hi Roland,
>> http://cr.openjdk.java.net/~roland/8244504/webrev.02/
Overall looks good to me. Some comments:
addnode.hpp
- Now that you've introduced these helper methods, shouldn't you also replace other usages (not only
loop opts)? For example, in ModINode::Ideal
loopPredicate.cpp:
- "kind predicates" -> "kinds of predicates"
- change in line 136 was already fixed as part of 8245714, right?
loopnode.cpp:
- please add brackets to lines 487/490/494/497
Best regards,
Tobias
More information about the hotspot-compiler-dev
mailing list