[aarch64-port-dev ] [EXT] Re: RFR(XS): Provide information when hitting a HaltNode for architectures other than x86

[Doerr, Martin]

Hi Andrew,

I still see "Instructions" section in hex. But I can live with that. PPC change is already pushed: 8244949: [PPC64] Reengineer assembler stop function

Thanks for taking care of the AArch64 version.

Best regards,
Martin


> -----Original Message-----
> From: Andrew Haley <aph at redhat.com>
> Sent: Mittwoch, 27. Mai 2020 15:04
> To: Doerr, Martin <martin.doerr at sap.com>; Derek White
> <derekw at marvell.com>; Ningsheng Jian <ningsheng.jian at arm.com>; Liu,
> Xin <xxinliu at amazon.com>; hotspot-compiler-dev at openjdk.java.net
> Cc: aarch64-port-dev at openjdk.java.net
> Subject: Re: [aarch64-port-dev ] [EXT] Re: RFR(XS): Provide information
> when hitting a HaltNode for architectures other than x86
> 
> On 15/05/2020 11:37, Doerr, Martin wrote:
> > Exactly, we get stop type + stop message + registers + instructions
> (unfortunately not disassembled for some reason) + nice stack trace.
> 
> The "some reason" is that you're not calling VMError::report_and_die
> correctly.
> 
> Do something like this:
> 
> +        VMError::report_and_die(INTERNAL_ERROR, msg, detail_msg,
> detail_args, thread,
> +                                pc, info, ucVoid, NULL, 0, 0);
> 
> I'm working on an AArch64 version now.
> 
> --
> Andrew Haley  (he/him)
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> https://keybase.io/andrewhaley
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671