[aarch64-port-dev ] RFR(XS): Provide information when hitting a HaltNode for architectures other than x86
Liu, Xin
xxinliu at amazon.com
Thu May 28 19:37:48 UTC 2020
Hi, Andrew,
Thank you to this JBS issue for aarch64. I think I understand the mechanism behind it. We always store and load 64 bits for a pointer and let type conversion do the job.
You patch looks good to me.
Thanks,
--lx
On 5/28/20, 9:53 AM, "Andrew Haley" <aph at redhat.com> wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
On 28/05/2020 11:02, Andrew Haley wrote:
>> Just one thing: for this instruction emit_int64((intptr_t)msg), can we safely say a pointer is always 64-bit on aarch64?
> That's a fair point. I'll change it: there's no need for that code to
> depend on pointer size.
http://cr.openjdk.java.net/~aph/8245986-2/
I'm trying to get better at not always assuming that pointers
and int64_t can be freely exchanged, or that the world is
little endian. I have a long way to go.
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-compiler-dev
mailing list