RFR: 8255672: Replace PhaseTransform::eqv by pointer equality check [v2]

[Tobias Hartmann]

On Mon, 2 Nov 2020 10:03:25 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added missing whitespace
>
> Looks good to me!

Thanks for the review Christian. I'd like to not merge the ifs because I think these are separate cases and I would like to keep the impact on surrounding code to a minimum. Are you okay with that?

> src/hotspot/share/opto/subnode.cpp line 458:
> 
>> 456:     // Convert "x - (x+y)" into "-y"
>> 457:     return new SubFNode(phase->makecon(TypeF::ZERO),in(2)->in(2));
>> 458:   }
> 
> Missing space before `in(2)->in(2)`.

Good catch!

-------------

PR: https://git.openjdk.java.net/jdk/pull/999