RFR: 8255766: Fix linux+arm64 build after 8254072

Andrew Haley aph at openjdk.java.net
Mon Nov 2 18:00:57 UTC 2020


On Mon, 2 Nov 2020 17:55:46 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Someone in hotspot team needs to determine if this is a "trivial" fix or not.
>
> A recently introduced checked cast[1] looks to be useful here, it would allow to remove the ad-hoc assert.
> 
> [1] https://github.com/openjdk/jdk/commit/3302d3adb5fbd5729c1677d927dd4c8af1c428a4

diff --git a/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp b/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
index eb6195fd675..92a07a84d2a 100644
--- a/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
+++ b/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
@@ -1498,8 +1498,7 @@ nmethod* SharedRuntime::generate_native_wrapper(MacroAssembler* masm,
 
   // Generate stack overflow check
   if (UseStackBanging) {
-    assert(StackOverflow::stack_shadow_zone_size() == (int)StackOverflow::stack_shadow_zone_size(), "must be same");
-    __ bang_stack_with_offset((int)StackOverflow::stack_shadow_zone_size());
+    __ bang_stack_with_offset(checked_cast<int>(StackOverflow::stack_shadow_zone_size()));
   } else {
     Unimplemented();
   }

-------------

PR: https://git.openjdk.java.net/jdk/pull/1013


More information about the hotspot-compiler-dev mailing list