RFR: 8255011: [TESTBUG] UnexpectedDeoptimizationAllTest.java timed out [v2]
Nils Eliasson
neliasso at openjdk.java.net
Wed Nov 4 15:59:10 UTC 2020
> Hi,
>
> This patch updates the code cache stress tests. I haven't been able to reproduce or retrieve a core file.
>
> What I can see is that the tests provokes compile storms, and that the single C1 thread (on a 4CPU system) sometimes has trouble keeping up. A factor may also be that the tests run time scale with the timeout time - so that the time allotted as margin before the timeout is only 20% of the total runtime. Combining this with Xcomp, and that the test may run concurrently with other stress tests, it is reasonable that a timeout may occur.
>
> I suggest to cap the tests to 60 seconds of testing. I've experimented with meassuring how much work is done and use that as a metric - but the different tests that use the CodeCacheStressRunner has completely different profiles.
>
> In UnexpectedDeoptimizationAllTest.java I have adjusted the sleep time to 100 millis between the invalidations of the entire code cache.
>
> In UnexpectedDeoptimizationTest.java I have added a sleep of 10 miilis between deoptimizing parts of the stack. The idea is to give the stack time to growth a bit before the next deoptimization. Otherwise the test might end up running mostly in the interpreter.
>
> Please review,
> Nils Eliasson
Nils Eliasson has updated the pull request incrementally with three additional commits since the last revision:
- changed wait time
- removed file
- simplify_timeout
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1030/files
- new: https://git.openjdk.java.net/jdk/pull/1030/files/cf3ec2cc..5050a2ef
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1030&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1030&range=00-01
Stats: 8 lines in 2 files changed: 0 ins; 5 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/1030.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1030/head:pull/1030
PR: https://git.openjdk.java.net/jdk/pull/1030
More information about the hotspot-compiler-dev
mailing list