RFR: 8255011: [TESTBUG] UnexpectedDeoptimizationAllTest.java timed out

Evgeny Nikitin enikitin at openjdk.java.net
Wed Nov 4 20:02:54 UTC 2020


On Wed, 4 Nov 2020 15:49:22 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> @neliasso ,
>> 
>> could you please explain why in `UnexpectedDeoptimizationAllTest` you "have adjusted the sleep time to 100 millis between the invalidations of the entire code cache"?
>
>> @neliasso ,
>> 
>> could you please explain why in `UnexpectedDeoptimizationAllTest` you "have adjusted the sleep time to 100 millis between the invalidations of the entire code cache"?
> 
> I was experimenting with different levels of contention. 10 millis + Xcomp gets 30% fewer methods compiled, but in all other cases 10 millis results in more compilations. It's a toss for me. 
> 
> I reverted since it doesn't really matter.

@neliasso, could you please explain how those compile storms cause timeouts? As far as I could find, the JVM doesn't wait for the threads to finish, it gives them approx. [10 seconds](http://hg.openjdk.java.net/jdk/jdk/file/ee1d592a9f53/src/hotspot/share/runtime/vmOperations.cpp#l388), and then just [exits](http://hg.openjdk.java.net/jdk/jdk/file/ee1d592a9f53/src/hotspot/share/runtime/vmOperations.cpp#l424).

So we only have to make sure that our 20% is larger than 10s + some reasonable margin, right?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1030


More information about the hotspot-compiler-dev mailing list