RFR: 8255563: Missing NULL checks after JDK-8233624

Vladimir Kozlov kvn at openjdk.java.net
Thu Nov 5 01:09:54 UTC 2020


On Thu, 5 Nov 2020 00:37:30 GMT, David Holmes <dholmes at openjdk.org> wrote:

> JDK-8233624 introduced a check for illegal native method names that will result in the `NativeLookup::*_jni_name` methods returning NULL. JVMCI `registerNativeMethods` uses these APIs without any check for a NULL return, however the methods being registered are part of the JVMCI implementation so should never have an illegal name, so adding a guarantee suffices to deal with that (see comments in JBS issue).

Looks good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1068


More information about the hotspot-compiler-dev mailing list