RFR: 8255011: [TESTBUG] UnexpectedDeoptimizationAllTest.java timed out [v3]

[Igor Ignatyev]

On Thu, 5 Nov 2020 09:46:08 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Hi, 
>> 
>> This patch updates the code cache stress tests. I haven't been able to reproduce or retrieve a core file. 
>> 
>> What I can see is that the tests provokes compile storms, and that the single C1 thread (on a 4CPU system) sometimes has trouble keeping up. A factor may also be that the tests run time scale with the timeout time - so that the time allotted as margin before the timeout is only 20% of the total runtime. Combining this with Xcomp, and that the test may run concurrently with other stress tests, it is reasonable that a timeout may occur.
>> 
>> I suggest to cap the tests to 60 seconds of testing. I've experimented with meassuring how much work is done and use that as a metric - but the different tests that use the CodeCacheStressRunner has completely different profiles. 
>> 
>> In UnexpectedDeoptimizationAllTest.java I have adjusted the sleep time to 100 millis between the invalidations of the entire code cache.
>> 
>> In UnexpectedDeoptimizationTest.java  I have added a sleep of 10 miilis between deoptimizing parts of the stack. The idea is to give the stack time to growth a bit before the next deoptimization. Otherwise the test might end up running mostly in the interpreter.
>> 
>> Please review,
>> Nils Eliasson
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comment

LGTM. however I'd like to you to wait for explcit 'ok' from Evgeny (@lepestock) as well.

BTW, you need to either update the title of this PR to `[TESTBUG] compiler/codecache/stress/UnexpectedDeoptimizationAllTest.java timed out` or change [8255011](https://bugs.openjdk.java.net/browse/JDK-8255011)'s title to `[TESTBUG] UnexpectedDeoptimizationAllTest.java timed out`

-- Igor

-------------

Marked as reviewed by iignatyev (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1030