RFR: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 9 08:04:53 UTC 2020


On Sat, 7 Nov 2020 07:50:17 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> src/hotspot/share/adlc/Test/i486.ad is empty.
> It might be better to remove it.
> Thanks.

Might also be a good time to rewrite the references to `x486.ad` to either `x86.ad` or `x86_32.ad` or `x86_64.ad`:

$ ack i486.ad src
src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
343:          // TODO: The encoding of D2I in i486.ad can cause an exception

src/hotspot/os_cpu/bsd_x86/os_bsd_x86.cpp
552:          // TODO: The encoding of D2I in i486.ad can cause an exception

src/hotspot/cpu/ppc/ppc.ad
3891:  // Comment taken from i486.ad:
3903:  // Comment taken from i486.ad:

src/hotspot/share/opto/parse2.cpp
2340:      // For i486.ad, FILD doesn't restrict precision to 24 or 53 bits.
2355:    // For i486.ad, rounding is always necessary (see _l2f above).

src/hotspot/share/opto/machnode.hpp
154:  // Only returns non-null value for i486.ad's indOffset32X

src/hotspot/share/opto/machnode.cpp
298:    // In i486.ad, indOffset32X uses base==RegI and disp==RegP,

src/hotspot/share/adlc/output_c.cpp
3003:      // See BugId 4796752, operand indOffset32X in i486.ad

src/hotspot/share/runtime/synchronizer.cpp
62:// variants of the enter-exit fast-path operations.  See i486.ad fast_lock(),

-------------

PR: https://git.openjdk.java.net/jdk/pull/1107


More information about the hotspot-compiler-dev mailing list