RFR: 8256325: Remove duplicate asserts in PhaseMacroExpand::expand_macro_nodes

[Aleksey Shipilev]

On Fri, 13 Nov 2020 10:56:11 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> [JDK-8239072](https://bugs.openjdk.java.net/browse/JDK-8239072) added a default case to the switch statement in PhaseMacroExpand::expand_macro_nodes:
> https://hg.openjdk.java.net/jdk/jdk/rev/cf319f17c647#l3.67
> 
> This allows to merge the "expansion must have deleted one node from macro list" asserts and remove the duplicate asserts.
> 
> Thanks,
> Tobias

Looks pretty simple and good. 

While you are here, you could also capitalize the macro and drop redundant semicolon:
    debug_only(int old_macro_count = C->macro_count(););
to:
    DEBUG_ONLY(int old_macro_count = C->macro_count();)

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1200