RFR: 8254016: Test8237524 fails with -XX:-CompactStrings option

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 16 13:36:03 UTC 2020


On Mon, 16 Nov 2020 13:22:08 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

> The test compares two strings created from same byte array: Latin vs UTF16. The expected effect (strings are different) is valid only for COMPACT_STRINGS=true case (otherwise both strings are treated as UTF16). Particularly on ARM32 test fails because CompactStrings is off by default.

Does this work when platform defaults to `-XX:-CompactStrings`? I.e. does it work for ARM32? I would prefer to `@require vm.opt.final.CompactStrings`, but seems like other tests already do `-XX:+CompactStrings` anyway, so this looks okay.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1226


More information about the hotspot-compiler-dev mailing list