RFR: 8256267: Relax compiler/floatingpoint/NaNTest.java for x86_32 and lower -XX:+UseSSE [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed Nov 18 17:27:59 UTC 2020


On Tue, 17 Nov 2020 00:42:20 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Indents and comments
>
> Why to run test code if you know the result will not match? Why not just skip testing?
> I thought about using `@requires vm.cpu.features` checks but your check in main() is simpler and more clear.

Do you still want me to make changes, @vnkozlov? I can throw `SkippedException` instead.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1187


More information about the hotspot-compiler-dev mailing list