RFR: 8033441: print line numbers with -XX:+PrintOptoAssembly [v2]

[Jason Tatton]

On Tue, 17 Nov 2020 20:03:10 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Jason Tatton has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactored linenumber output to print_method_with_lineno method and tweaked unit test
>
> test/hotspot/jtreg/compiler/arguments/TestPrintOptoAssemblyLineNumbers.java line 29:
> 
>> 27:  * @summary Test to ensure that line numbers are now present with the -XX:+PrintOptoAssembly command line option
>> 28:  *
>> 29:  * @requires vm.debug == true
> 
> the flag `PrintOptoAssembly` comes from c2. 
> IMHO, you need `@requires vm.compiler2.enabled` instead of vm.debug == true.

Thanks for raising this, I found that without `vm.debug == true` the test will fail if run on a non debug build (as the expected output is only available on the debug build). But I have adjusted the `@requires` to include `vm.compiler2.enabled`

-------------

PR: https://git.openjdk.java.net/jdk/pull/1272