RFR: 8033441: print line numbers with -XX:+PrintOptoAssembly

[Xin Liu]

On Wed, 18 Nov 2020 21:39:10 GMT, Jason Tatton <github.com+70893615+jasontatton-aws at openjdk.org> wrote:

>> Hi all,
>> 
>> Here is a patch which adds line number information to the `-XX:+PrintOptoAssembly` cmd line option output.
>> 
>> A new unit test is provided for this functionality. Note that the build must have debugging enabled for the test to be relevant and enabled.
>> 
>> Here is an example output:-
>> before:
>>         # Tryme::foo @ bci:3  L[0]=_ STK[0]=#NULL STK[1]=#Ptr0x0000ffff340089c0
>> 
>> after:
>>         # Tryme::foo @ bci:3 (line 12)  L[0]=_ STK[0]=#NULL STK[1]=#Ptr0x0000ffff1008fd80
>> 
>> Testing:
>> I have run tier 1/2 on linux on x86 and aarch64. With a `--enable-debug` build.
>
>> Two code snippets are same logic. Maybe it's a good idea to have a private member function.
>> you can treat this as an optional suggestion.
>>
> 
> Thanks Xin, I have refactored the code to use a private member function as advised

We do need vm.debug == true in the test because `PrintOptoAseembly` prints nothing in release build. 
Your patch looks good to me, but  we still need a review to approve it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1272