RFR: 8247732: validate user-input intrinsic_ids in ControlIntrinsic
Xin Liu
xliu at openjdk.java.net
Thu Nov 19 00:22:05 UTC 2020
On Wed, 18 Nov 2020 21:47:40 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:
>> 8247732: validate user-input intrinsic_ids in ControlIntrinsic
>
> In general - I like it a lot. I will take it for a spin and go through the PR.
>
> A heads up is that this PR will clash a bit with https://github.com/openjdk/jdk/pull/1276 which adds validation of the compile commands. Your change to compilerOracle.*pp seems well contained so there should be no problem to merge them.
Hi, Nils,
Thank you for reviewing the lengthy PR!
The major part is to extend the testing framework to include ControlIntrinsic. It may be also useful to test other compiler directives whose arguments are ccstr/ccstrlist.
I am watching JDK-8256508. I will update this PR accordingly if it needs.
thanks,
--lx
-------------
PR: https://git.openjdk.java.net/jdk/pull/1179
More information about the hotspot-compiler-dev
mailing list