RFR: 6232281: -XX:-UseLoopSafepoints causes assert(v_false, "Parse::remove_useless_nodes missed this node") [v2]

[Roberto Castañeda Lozano]

On Thu, 19 Nov 2020 10:33:30 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove redundant -Xbatch option in test case
>>  - Remove confusing comment in test case
>
> Looks good to me.

Thanks for reviewing Nils and Tobias! I have updated the test with the feedback from Tobias.

> test/hotspot/jtreg/compiler/arguments/TestDisableUseLoopSafepoints.java line 31:
> 
>> 29:  *          missed this node" message when UseLoopSafepoints is disabled. Note
>> 30:  *          that other parts of C2 assume that this option is enabled and might
>> 31:  *          fail in more subtle ways otherwise.
> 
> Please make sure that this test does not trigger any of these other failures when executed in the CI.

The last part of the comment referred to the case `-XX:-UseLoopSafepoints` is used on more complex methods than the tested one. I have just removed it, as it was confusing and probably doing more harm than good. The test succeeds for all CI debug configurations and is correctly skipped for all CI release configurations.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1311