RFR: 8251925: C2: RenaissanceStressTest fails with assert(!had_error): bad dominance [v3]
Christian Hagedorn
chagedorn at openjdk.java.net
Thu Nov 19 17:06:21 UTC 2020
On Thu, 19 Nov 2020 11:35:49 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Christian Hagedorn has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> Otherwise looks good to me.
@TobiHartmann Thanks for your review!
> src/hotspot/share/opto/superword.cpp line 73:
>
>> 71: _lpt(NULL), // loop tree node
>> 72: _lp(NULL), // CountedLoopNode
>> 73: _pre_loop_head(NULL), // Pre loop CountedLoopNode
>
> Is this field really needed? Can't we just retrieve the pre-loop head via `_pre_loop_end->loopnode()`?
You're right, it is not really needed. I removed it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/954
More information about the hotspot-compiler-dev
mailing list