RFR: 6232281: -XX:-UseLoopSafepoints causes assert(v_false, "Parse::remove_useless_nodes missed this node") [v2]
Vladimir Kozlov
kvn at openjdk.java.net
Thu Nov 19 17:49:07 UTC 2020
On Thu, 19 Nov 2020 12:44:18 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Check for nodes missed by `remove_useless_nodes()` only if PhaseRemoveUseless has actually been run. This makes it possible to use `-XX:-UseLoopSafepoints` without crashing trivially, although implicit assumptions in other parts of C2 about the existence of loop safepoints might lead to more subtle failures for more complex methods.
>
> Roberto Castañeda Lozano has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove redundant -Xbatch option in test case
> - Remove confusing comment in test case
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1311
More information about the hotspot-compiler-dev
mailing list