RFR: 8256073: Improve vector rematerialization support
Vladimir Kozlov
kvn at openjdk.java.net
Thu Nov 19 18:19:13 UTC 2020
On Thu, 19 Nov 2020 18:14:36 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> src/hotspot/share/prims/vectorSupport.cpp line 94:
>>
>>> 92: case T_FLOAT: arr->bool_at_put(index, (*(jint*)addr) != 0); break;
>>> 93: case T_LONG: // fall-through
>>> 94: case T_DOUBLE: arr->bool_at_put(index, (*(jlong*)addr) != 0); break;
>>
>> Why you push `bool` value for everything?!!!
>
> Okay. After reading code more I understand that array is boolean type for case when `is_mask` is `true`. So changes are correct.
May be you need separate method to avoid this confusion. The code is separate anyway.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1136
More information about the hotspot-compiler-dev
mailing list