RFR: 8251925: C2: RenaissanceStressTest fails with assert(!had_error): bad dominance [v4]
Christian Hagedorn
chagedorn at openjdk.java.net
Fri Nov 20 07:16:06 UTC 2020
On Thu, 19 Nov 2020 17:59:27 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Remove _pre_loop_head field
>> - Update comments and invariant selection in offset_plus_k
>> - Check dominance with pre loop head instead of tail
>> - 8251925: C2: RenaissanceStressTest fails with assert(!had_error): bad dominance
>
> Unfortunately with forced push I can't see incremental update.
> Based on last update comments changes are reasonable.
@vnkozlov Thanks for reviewing again! Yes, that's unfortunate, I wasn't aware of that. I will try to do a merge next time.
-------------
PR: https://git.openjdk.java.net/jdk/pull/954
More information about the hotspot-compiler-dev
mailing list