RFR: 8256633: Fix product build on Windows+Arm64 [v2]

Aleksey Shipilev shade at openjdk.java.net
Fri Nov 20 11:04:16 UTC 2020


On Fri, 20 Nov 2020 11:01:45 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

>> Fix this warning:
>> C:\work\openjdk-jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(508): error C2220: the following warning is treated as an error
>> C:\work\openjdk-jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(508): warning C4390: ';': empty controlled statement found; is this the intent?
>> 
>> Thanks to @magicus to bring that to my attention.
>
> Bernhard Urban-Forster has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review feedback

Looks fine. Not sure how sensible are negative shifts, but new code follows the current semantics exactly.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1312


More information about the hotspot-compiler-dev mailing list