RFR: 8033441: print line numbers with -XX:+PrintOptoAssembly [v3]

[Tobias Hartmann]

On Thu, 19 Nov 2020 21:50:20 GMT, Jason Tatton <github.com+70893615+jasontatton-aws at openjdk.org> wrote:

>> Hi all,
>> 
>> Here is a patch which adds line number information to the `-XX:+PrintOptoAssembly` cmd line option output.
>> 
>> A new unit test is provided for this functionality. Note that the build must have debugging enabled for the test to be relevant and enabled.
>> 
>> Here is an example output:-
>> before:
>>         # Tryme::foo @ bci:3  L[0]=_ STK[0]=#NULL STK[1]=#Ptr0x0000ffff340089c0
>> 
>> after:
>>         # Tryme::foo @ bci:3 (line 12)  L[0]=_ STK[0]=#NULL STK[1]=#Ptr0x0000ffff1008fd80
>> 
>> Testing:
>> I have run tier 1/2 on linux on x86 and aarch64. With a `--enable-debug` build.
>
> Jason Tatton has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - fix whitespace error
>  - adjusted test to check for line number information only if c2 optimizer output is present on console output

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1272