Integrated: 6232281: -XX:-UseLoopSafepoints causes assert(v_false, "Parse::remove_useless_nodes missed this node")
Roberto Castañeda Lozano
rcastanedalo at openjdk.java.net
Fri Nov 20 12:11:03 UTC 2020
On Thu, 19 Nov 2020 09:05:06 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> Check for nodes missed by `remove_useless_nodes()` only if PhaseRemoveUseless has actually been run. This makes it possible to use `-XX:-UseLoopSafepoints` without crashing trivially, although implicit assumptions in other parts of C2 about the existence of loop safepoints might lead to more subtle failures for more complex methods.
This pull request has now been integrated.
Changeset: eb35ade9
Author: Roberto Castañeda Lozano <rcastanedalo at openjdk.org>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/eb35ade9
Stats: 44 lines in 2 files changed: 43 ins; 0 del; 1 mod
6232281: -XX:-UseLoopSafepoints causes assert(v_false,"Parse::remove_useless_nodes missed this node")
Check for nodes missed by remove_useless_nodes() only if PhaseRemoveUseless has
actually been run. This makes it possible to use -XX:-UseLoopSafepoints without
crashing trivially, although implicit assumptions in other parts of C2 about the
existence of loop safepoints might lead to more subtle failures for more complex
methods.
Reviewed-by: neliasso, thartmann, kvn
-------------
PR: https://git.openjdk.java.net/jdk/pull/1311
More information about the hotspot-compiler-dev
mailing list