RFR: 8256633: Fix product build on Windows+Arm64 [v2]

[Andrew Haley]

On Fri, 20 Nov 2020 11:04:15 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

>> Fix this warning:
>> C:\work\openjdk-jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(508): error C2220: the following warning is treated as an error
>> C:\work\openjdk-jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(508): warning C4390: ';': empty controlled statement found; is this the intent?
>> 
>> Thanks to @magicus to bring that to my attention.
>
> Bernhard Urban-Forster has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review feedback

src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 510:

> 508:             assert(_ext.shift() == (int)size, "bad shift");
> 509:           }
> 510:           i->f(_ext.shift() > 0, 12);

IMO, if this is to be fixed it should be fixed properly, viz:
--- a/src/hotspot/share/utilities/debug.hpp
+++ b/src/hotspot/share/utilities/debug.hpp
@@ -45,7 +45,7 @@ bool handle_assert_poison_fault(const void* ucVoid, const void* faulting_address
 
 // assertions
 #ifndef ASSERT
-#define vmassert(p, ...)
+#define vmassert(p, ...) do { } while (0)
 #else

-------------

PR: https://git.openjdk.java.net/jdk/pull/1312