RFR: 8249144: Potential memory leak in TypedMethodOptionMatcher

Tobias Hartmann thartmann at openjdk.java.net
Mon Nov 23 07:38:00 UTC 2020


On Fri, 20 Nov 2020 14:45:02 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> TypedMethodOptionMatcher owns ccstr value (vs. os::strdup_check_oom()), but never frees it in destructor.
> 
> It does not appear to a real issue so far, because TypedMethodOptionMatcher seems immortal. Given it releases _option 
> string, it should also release ccstr value.
> 
> This patch has been reviewed https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-July/042356.html, but I lost track of it during repo migration.

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1353


More information about the hotspot-compiler-dev mailing list